Skip to content

Don't assume footer is present in _ConsoleOutputState builder.#9342

Merged
biggs0125 merged 2 commits intoflutter:masterfrom
biggs0125:fix-footer
Jul 23, 2025
Merged

Don't assume footer is present in _ConsoleOutputState builder.#9342
biggs0125 merged 2 commits intoflutter:masterfrom
biggs0125:fix-footer

Conversation

@biggs0125
Copy link
Contributor

Resolves this errors:

Null check operator used on a null value
file:///b/s/w/ir/x/w/devtools/packages/devtools_app/lib/src/shared/console/console.dart 214:37 \| build
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5824:27 \| build
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5875:11 \| performRebuild
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5866:11 \| _firstBuild
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5692:5 \| mount

@biggs0125 biggs0125 requested a review from a team as a code owner July 23, 2025 02:24
@biggs0125 biggs0125 requested review from elliette and removed request for a team July 23, 2025 02:24
@elliette
Copy link
Member

Thanks! One request but otherwise LGTM.

I think the test failures might be flakes, I'm re-running them to see.

@biggs0125 biggs0125 requested a review from elliette July 23, 2025 18:05
@biggs0125 biggs0125 merged commit 4347294 into flutter:master Jul 23, 2025
41 checks passed
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
…er#9342)

---------

Co-authored-by: Nate Biggs <natebiggs@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants