Textfield focus issue workaround#9091
Merged
elliette merged 3 commits intoflutter:masterfrom Apr 4, 2025
Merged
Conversation
| super.initState(); | ||
| // Workaround for https://github.com/flutter/devtools/issues/8929. | ||
| // Workaround for https://github.com/flutter/flutter/issues/155265. | ||
| setUpTextFieldFocusFixHandler(); |
Member
There was a problem hiding this comment.
do we still need this since we now have it at the root of DevToolsApp?
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
Have we done thorough testing to make sure that we are not causing any unforeseen side effects on other parts of the DevTools app? (different screens, embedded and non-embedded, vs code & intelliJ, devtools extensions, etc.)
Member
Author
I've done the following testing, will need to finish testing tomorrow morning:
|
kenzieschmoll
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the workaround for flutter/flutter#155265 to ALL of DevTools, not just the Property Editor.
Incorporates @ditman's suggestions as well to check if we are in a
<flutter-view>first before callingblur(thank you!)FYI @DanTup @jwren
Also FYI @johnpryan (Dartpad has the same issue, so adding this workaround there might be a good idea until it's fixed upstream in Flutter)