Migrate generate_code.sh to devtools_tool for Windows compatibility#6579
Merged
auto-submit[bot] merged 6 commits intoflutter:masterfrom Oct 24, 2023
Merged
Migrate generate_code.sh to devtools_tool for Windows compatibility#6579auto-submit[bot] merged 6 commits intoflutter:masterfrom
auto-submit[bot] merged 6 commits intoflutter:masterfrom
Conversation
tool/generate_code.sh
Outdated
| @@ -10,37 +10,9 @@ RELATIVE_PATH_TO_SCRIPT="${BASH_SOURCE[0]}" | |||
| # The directory that this script is located in. | |||
| TOOL_DIR=`dirname "${RELATIVE_PATH_TO_SCRIPT}"` | |||
Member
There was a problem hiding this comment.
lets just delete this file altogether and call devtools_tool generate-code everywhere we were previously calling generate_code.sh
Contributor
Author
There was a problem hiding this comment.
Done! I wasn't sure if others might have scripts/keybinds to call it, but this probably makes more sense. I'll ping a note in Discord about it too.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows I've had to run
build_runner buildmanually in each folder so this adds a devtools_tool command in Dart and calls it from the old bash script.