-
Notifications
You must be signed in to change notification settings - Fork 366
Open
Labels
P3issues we think are valid but not importantissues we think are valid but not importantscreen: cpu profilerIssues related to the CPU Profiler screenIssues related to the CPU Profiler screen
Description
The functions called in generateFromCpuSamples must be called in that particular order. This is because of function side effects:
- Generating the stack frames both creates the timeline tree and assigns frame IDs to every node in the tree
- Creating the sample events expects that the tree has already been created, and that the frame IDs have been assigned to every node
Ideally we should refactor the code so that we aren't dependent on hidden side effects.
Metadata
Metadata
Assignees
Labels
P3issues we think are valid but not importantissues we think are valid but not importantscreen: cpu profilerIssues related to the CPU Profiler screenIssues related to the CPU Profiler screen