This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Reland "[Darwin] Disable NSAsserts in release builds. #860"#919
Closed
hellohuanlin wants to merge 1 commit intoflutter:masterfrom
Closed
Reland "[Darwin] Disable NSAsserts in release builds. #860"#919hellohuanlin wants to merge 1 commit intoflutter:masterfrom
hellohuanlin wants to merge 1 commit intoflutter:masterfrom
Conversation
Author
|
Need to make sure this doesn't fail the CI for engine repo. |
8 tasks
chinmaygarde
approved these changes
Nov 25, 2024
Author
|
This is still pending the other build to pass. Let me convert it to draft |
Member
|
(triage): I am going to close this one since after the mono-repo merge the buildroot is now part of the regular flutter/flutter repository. If this change is still needed, please open a new PR on flutter/flutter. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to make sure this doesn't fail the CI for engine repo.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.