This repository was archived by the owner on Apr 21, 2025. It is now read-only.
More changes required for the GN updates.#481
Merged
chinmaygarde merged 1 commit intomasterfrom Jul 13, 2021
Merged
Conversation
These should have been a part of 647c7f8. But the switfshader targets are apparently not built on non-x64 hosts. So running the updated GN was not failing on M1 hosts.
zanderso
approved these changes
Jul 13, 2021
dnfield
approved these changes
Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These should have been a part of 647c7f8. But the switfshader targets are apparently not built on non-x64 hosts. So running the updated GN was not failing on M1 hosts.