This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Conversation
Contributor
|
flutter/engine#18045 is my ongoing attempt to roll that buildroot change into the engine, and it's definitely broken. I thought I had one pass before landing 392 that worked, but looking back it looks like I missed the Windows exception and thought it was just the unrelated Linux failure. |
xster
approved these changes
Aug 15, 2020
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
…" (flutter#396) This reverts commit 97f6f00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #392
Temporarily revert so that changes in #395 can be rolled.
This seems to cause https://ci.chromium.org/p/flutter/builders/try/Windows%20Host%20Engine/11969? which is part of flutter/engine#20479