Add a github action to check tidy#93
Merged
swift-kim merged 5 commits intoflutter-tizen:masterfrom May 13, 2021
Merged
Conversation
Contributor
Author
|
If you guys like this PR, I want to make a similar PR for flutter-tizen/engine |
pkosko
reviewed
May 11, 2021
Contributor
pkosko
left a comment
pkosko
left a comment
There was a problem hiding this comment.
IMHO this is very important contribution to automatically maintain common coding style during PR.
swift-kim
reviewed
May 11, 2021
bbrto21
commented
May 11, 2021
* This format is based on Google Style
* check-tidy came from Samsusng/escargot
* How to run: tools/check_tidy.py
You can specify clang-format using '--clang-format'
The clang-format being used by vscode is usually in
~/.vscode/extensions/ms-vscode.cpptools-{VERSION}-insiders/LLVM/bin/
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
reviewed
May 12, 2021
.github/workflows/format.yml
Outdated
| sudo apt-get update | ||
| sudo apt-get install clang-format-11 | ||
| - name: Check tidy | ||
| run: tools/check_tidy.py |
Member
There was a problem hiding this comment.
for consistency with the dart job
Suggested change
| run: tools/check_tidy.py | |
| run: tools/check_tidy.py --dir packages |
Can check_tidy.py resolve a relative directory path?
Member
|
By the way this PR itself is failing the check. |
Contributor
Author
it caused by config file generated by clang-foramt12 |
Signed-off-by: Boram Bae <boram21.bae@samsung.com>
swift-kim
approved these changes
May 12, 2021
HakkyuKim
approved these changes
May 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes :
How to run:
You can specify clang-format using '--clang-format'
The clang-format being used by vscode is usually in
~/.vscode/extensions/ms-vscode.cpptools-{VERSION}-insiders/LLVM/bin/