Use proc table for embedder APIs

[bbrto21]

• Use the proc table like other platform implementations
• Use FlutterEngine as private memeber of FlutterTizenEngine
• Only FlutterTizenEngine is dependent on FlutterEngine

Signed-off-by: Boram Bae boram21.bae@samsung.com

[bbrto21]

I will make additional changes after #86 merged

[swift-kim]

As far as I know the only advantage of using proc table is improved testability. So there's no benifit for us because we don't have any tests. Still this change looks good.

[bbrto21]

Yes, you're right. I thought we would need it later but It is a simple change, so I did it right away 😄

[bbrto21]

@swift-kim Well... I have a question. it seems that our engine always has NDEBUG turned on both release and debug.
It doesn't seem very important, but... is it the correct configuration?

[swift-kim]

@bbrto21

1. NDEBUG should be defined for release builds only:

   https://github.com/flutter/buildroot/blob/ef50dec1f85ee435e967505f460d2c0ce6fde58e/build/config/BUILD.gn#L84-L85

2. The is_debug flag depends on the --unoptimized build option, but not the --runtime-mode option - I don't know why:

   engine/tools/gn

   Line 114 in 9f408ef

   gn_args['is_debug'] = args.unoptimized

   May be related to the change Change the "develop" runtime mode back to "debug" and rename the "deb… flutter/engine#2669.

3. We don't set the option in the CI build:

   engine/azure-pipelines.yml

   Lines 72 to 82 in 9f408ef

   	flutter/tools/gn \
   	--target-os linux \
   	--linux-cpu $(arch) \
   	--target-toolchain `pwd`/tizen_tools/toolchains \
   	--target-sysroot `pwd`/tizen_tools/sysroot/$(arch) \
   	--target-triple $(targetTriple) \
   	--runtime-mode $(mode) \
   	--embedder-for-target \
   	--disable-desktop-embeddings \
   	--build-tizen-shell
   	ninja -C out/linux_$(mode)_$(arch)

So it's a bug. 😨 We need to fix our build config.

It's not something that requires a fix. If you want to run the engine/embedder in checked mode for debugging purpose, you can enable the --unoptimized option when configuring your local build.

[bbrto21]

So it's a bug. We need to fix our build config.

@swift-kim @pwasowski2
if it means that use --unoptimized for debug mode, I think that the symbol resolution will succeed

[swift-kim]

Beautiful!