Fix font breaking issues#69
Merged
bbrto21 merged 3 commits intoflutter-tizen:flutter-2.0.1-tizenfrom Apr 23, 2021
HakkyuKim:fix-font-breaking-issue
Merged
Fix font breaking issues#69bbrto21 merged 3 commits intoflutter-tizen:flutter-2.0.1-tizenfrom HakkyuKim:fix-font-breaking-issue
bbrto21 merged 3 commits intoflutter-tizen:flutter-2.0.1-tizenfrom
HakkyuKim:fix-font-breaking-issue
Conversation
bwikbs
reviewed
Apr 21, 2021
+ adjust azure pipeline
Author
|
I couldn't solve the issue using fontconfig, I will leave it as future work. |
swift-kim
approved these changes
Apr 23, 2021
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
No meaningful difference in performance.
Application STIME PSS RSS
com.example.font_original 483 37887 53086
com.example.font_pr 489 37888 53087(measured on rpi4-arm64 with a counter sample)
|
@HakkyuKim I am curious whether we can use this plugin without FontConfig or not. Can you check it? |
bbrto21
approved these changes
Apr 23, 2021
Member
|
It seems I did something wrong in the measurement above. I measured the app startup time again on my Galaxy Watch (R800) and the result is as follows: Apparently there is a serious performance problem triggered by this change. p.s. This is the correct result on rpi4-arm64: |
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator + adjust azure pipeline
bbrto21
added a commit
to bbrto21/engine
that referenced
this pull request
Jun 11, 2021
This reverts commit 28dbd02.
bbrto21
added a commit
to bbrto21/engine
that referenced
this pull request
Jun 22, 2021
This reverts commit 5552dd5.
Merged
bwikbs
pushed a commit
that referenced
this pull request
Jun 23, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator + adjust azure pipeline
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator + adjust azure pipeline
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator + adjust azure pipeline
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
…tiplied source colors (#69)
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Allow multiple default fonts for localizations * Update fallback fonts from tv profile * Add fonts in wearable and tv emulator
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still looking into other options, but this is the only working solution I have.With this change, the engine must be built without the--enable-fontconfigoption.With fontconfig, Rendering SamsungOneUI font for the English language works on TV devices but doesn't on watches. I'm still not sure why the behavior is different on watch devices. I could dig deeper but I think the current solution is enough to solve the issue.
Fixes flutter-tizen/flutter-tizen#72.