Open
Conversation
Introduce arrow-ext and expose parquet reader/writer. Introduce ParquetEngine abstraction into flow-php/parquet. Make flow-php/parquet use engines based on arrow extension availability.
norberttech
force-pushed
the
rs-arrow-extension
branch
5 times, most recently
from
b831844 to
e0280f0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2268 +/- ##
==========================================
+ Coverage 82.88% 83.19% +0.30%
==========================================
Files 1361 1368 +7
Lines 50797 51220 +423
==========================================
+ Hits 42104 42612 +508
+ Misses 8693 8608 -85
🚀 New features to boost your workflow:
|
norberttech
force-pushed
the
rs-arrow-extension
branch
from
e0280f0 to
eb55e51
Compare
ptondereau
reviewed
Mar 25, 2026
ptondereau
left a comment
ptondereau
left a comment
There was a problem hiding this comment.
This is mostly good here! Great work!
I left some comments. Please don't hesitate to acknowledge
Member
Author
|
@ptondereau I believe it should be good now, thanks for your help! If you want to take another look, I'm probably going to aim to merge this one tomorrow |
|
LGTM! |
allow to upload partial coverages from different workflows using flags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security
Heads Up - I'm not rust developer and I don't have solid rust experience, building this extension was a learning process inspired by @ptondereau
Reviews, especially the rust part are welcome!
To use extension in nix shell just use
nix-shellwhich has argumentwith-arrow-extset by default totrue.To develop the extension (compile it and run tests) use
nix-shell --arg with-rust=true