Skip to content

PHP 8 support#308

Closed
adlenton wants to merge 1 commit intofirebase:masterfrom
adlenton:php-8-support
Closed

PHP 8 support#308
adlenton wants to merge 1 commit intofirebase:masterfrom
adlenton:php-8-support

Conversation

@adlenton
Copy link

Hi,

to prepare for PHP 8, I added it to the travis config and adjusted the phpunit composer dependency to allow picking up phpunit 9.4.
Please let me know if you'd prefer this to be solved differently.

@google-cla
Copy link

google-cla bot commented Oct 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 27, 2020
@adlenton
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Oct 27, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 27, 2020
- added php 8 to travis config
- allow phpunit 9 to be used
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 27, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@bshaffer
Copy link
Collaborator

this has been added to github actions in #331

@bshaffer bshaffer closed this May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants