chore: update minimum cmake version to 3.22 #1812

AustinBenoit · 2026-01-08T17:52:02Z

Description

Provide details of the change, and generalize the change in the PR title above.
chore: update minimum cmake version to 3.22. This would seem to help out flutterfire as they are using a new version of cmake. Additionally cmake 4.0 has dropped support for cmake version < 3.5. This change will help keep the CPP SDK buildable by recent version or CMake. It will also allow us to take advantage of some Cmake changes to simplify our scripts like finding python versions and downloading external dependencies.

We are limited to 3.22 as the current version of android we are using has this as the default version included.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Build everything locally and will run full test on this change.

Type of Change

Place an x the applicable box:

Bug fix. Add the issue # below if applicable.
New feature. A non-breaking change which adds functionality.
[ X] Other, such as a build process or documentation change.

Notes

Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
Read the contribution guidelines CONTRIBUTING.md.
Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

gemini-code-assist · 2026-01-08T17:52:38Z

Summary of Changes

Hello @AustinBenoit, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the minimum CMake version required for building the Firebase C++ SDK and its various sub-projects to 3.30. This essential maintenance update ensures the SDK remains compatible with contemporary CMake environments, supports external dependencies like FlutterFire, and allows the development team to leverage modern CMake functionalities for more streamlined and efficient build processes.

Highlights

Minimum CMake Version Update: The minimum required CMake version across the Firebase C++ SDK project and its sub-components has been uniformly updated to 3.30.
Compatibility and Future-Proofing: This update ensures compatibility with newer CMake versions, particularly in light of CMake 4.0 dropping support for versions older than 3.5, and aligns with projects like FlutterFire that utilize more recent CMake versions.
Enabling Modern CMake Features: The change facilitates the use of modern CMake features, which can simplify build scripts, such as improved methods for finding Python versions and managing external dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly updates the minimum required CMake version to 3.30 across all relevant CMakeLists.txt files. This is a valuable maintenance task that will help keep the SDK buildable with modern tools and allow for future improvements to the build scripts. The related changes, such as adding project() calls where they were missing, are also good improvements.

I have one minor suggestion for consistency.

As you noted in the description, this version bump opens the door for modernizing the CMake scripts. As a follow-up, you might consider:

Replacing find_program(FIREBASE_PYTHON_EXECUTABLE ...) with find_package(Python COMPONENTS Interpreter REQUIRED). This is the modern way to find Python and provides an imported target Python::Interpreter.
Using FetchContent instead of ExternalProject_Add for downloading external dependencies. FetchContent makes dependencies available at configure time, which can simplify the build logic.

Overall, this is a solid and necessary update.

gemini-code-assist · 2026-01-08T17:54:45Z

ios_pod/empty_CMakeLists.txt

 # limitations under the License.

-# Stub cmake project to enable pod files to be installed against
+cmake_minimum_required (VERSION 3.30)


For consistency with the other CMakeLists.txt files updated in this pull request, please remove the space between cmake_minimum_required and the opening parenthesis. Most other files in this PR have had this space removed.

cmake_minimum_required(VERSION 3.30)

github-actions · 2026-01-08T17:58:02Z

❌ Integration test FAILED

Requested by @AustinBenoit on commit 2e370fe
Last updated: Tue Feb 10 13:37 PST 2026
View integration test log & download artifacts

Failures	Configs
auth	(7 items) [TEST] [FAILURE] [Linux] [1/2 ssl_lib: x64] [1/2 build_type: openssl] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails [TEST] [FAILURE] [Linux] [1/2 ssl_lib: x86] [1/2 build_type: boringssl] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails [TEST] [FAILURE] [Windows] [1/2 ssl_lib: x64] [openssl] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails [TEST] [FAILURE] [Windows] [All 2 ssl_lib] [boringssl] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails [TEST] [FAILURE] [tvOS] [macos] [tvos_simulator] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/4 android_device: android_target] (1 failed tests) CRASH/TIMEOUT [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target] (1 failed tests) FirebaseAuthTest.TestSignInWithBadEmailFails
firestore	(5 items) [TEST] [ERROR] [iOS] [macos] [All 2 ios_device] [TEST] [ERROR] [tvOS] [macos] [tvos_simulator] [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: emulator_ftl_latest] (3 failed tests) AggregateCountTest.TestQueriesCanUseNotEqualFiltersWithDocIds AggregateCountTest.TestQueriesCanUseNotInFiltersWithNull AggregateCountTest.TestQueriesCanUseNotInFiltersWithObject [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/4 android_device: emulator_ftl_target] (1 failed tests) CRASH/TIMEOUT [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/4 android_device: emulator_ftl_latest] (2 failed tests) FieldsTest.TestNestedFieldsCanBeUsedInQueryFilters FirestoreTest.TestCanReadNonExistentDocuments

Add flaky tests to go/fpl-cpp-flake-tracker

AustinBenoit · 2026-01-09T20:19:58Z

Ah ok Integration tests / test-tvos-macos-14-tvos_simulator (pull_request) and Integration tests / test-desktop-windows-latest-x86-boringssl (pull_request) look to be failing due to other issues. I'll put fixes up for them and see where we are.

3.30 was causing issues with the Android builds so it makes more sense to start with a 3.22 upgrade and then try for 4.X upgrade later. We will still get most of pros when doing this upgrade anyways.

release_build_files/CMakeLists.txt

a-maurice · 2026-02-10T01:10:06Z

release_build_files/CMakeLists.txt

+cmake_minimum_required(VERSION 3.22)

-cmake_minimum_required(VERSION 3.1)
+project (firebase_prebuilt NONE)


What's the purpose of adding the project?

This is to get rid of a warning in version < 3.15 cmake just implicitly adds a project https://cmake.org/cmake/help/v3.14/command/project.html#usage

From the 3.14 docs:

The top-level CMakeLists.txt file for a project must contain a literal, direct call to the project() command; loading one through the include() command is not sufficient. If no such call exists CMake will implicitly add one to the top that enables the default languages (C and CXX).

But 3.15+ Cmake will now issue a warning if you don't explicitly set a project
https://cmake.org/cmake/help/v3.14/command/project.html#usage

From the 3.15 docs:

The top-level CMakeLists.txt file for a project must contain a literal, direct call to the project() command; loading one through the include() command is not sufficient. If no such call exists, CMake will issue a warning and pretend there is a project(Project) at the top to enable the default languages (C and CXX).

Just want to suppress the warning

ios_pod/empty_CMakeLists.txt

a-maurice · 2026-02-10T01:10:33Z

ios_pod/empty_CMakeLists.txt

-cmake_minimum_required (VERSION 3.1)
-
-project (GetPods CXX)
+project (empty CXX)


Why rename the project?

Oh sorry, that is an artifact of playing around with things to see what they all did. Reverted.

gemini-code-assist bot reviewed Jan 8, 2026

View reviewed changes

AustinBenoit added skip-release-notes Skip release notes check tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jan 8, 2026

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jan 8, 2026

github-actions bot added the tests: failed This PR's integration tests failed. label Jan 8, 2026

AustinBenoit changed the title ~~chore: update minimum cmake version to 3.30~~ chore: update minimum cmake version to 3.22 Jan 8, 2026

AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jan 8, 2026

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Jan 8, 2026

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 8, 2026

AustinBenoit added 3 commits February 6, 2026 10:30

chore: update minimum cmake version to 3.30

b760743

Chore: update to 3.22

ee17782

3.30 was causing issues with the Android builds so it makes more sense to start with a 3.22 upgrade and then try for 4.X upgrade later. We will still get most of pros when doing this upgrade anyways.

fixup: the change now requires a cxx label so its included

c98cc61

AustinBenoit force-pushed the update-cmake-3.30 branch from dbb69b6 to c98cc61 Compare February 6, 2026 15:30

AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: failed This PR's integration tests failed. labels Feb 6, 2026

github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Feb 6, 2026

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 6, 2026

AustinBenoit requested a review from a-maurice February 9, 2026 21:12

a-maurice reviewed Feb 10, 2026

View reviewed changes

Fix up the project name changed an removed comments

95ff5ec

Make project name consistent

dfd6f9f

AustinBenoit added tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). and removed tests: failed This PR's integration tests failed. labels Feb 10, 2026

github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Feb 10, 2026

a-maurice approved these changes Feb 10, 2026

View reviewed changes

github-actions bot added the tests: failed This PR's integration tests failed. label Feb 10, 2026

firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 10, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update minimum cmake version to 3.22 #1812

chore: update minimum cmake version to 3.22 #1812

Uh oh!

AustinBenoit commented Jan 8, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 8, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 8, 2026

Uh oh!

github-actions bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

AustinBenoit commented Jan 9, 2026

Uh oh!

Uh oh!

a-maurice Feb 10, 2026

Uh oh!

AustinBenoit Feb 10, 2026

Uh oh!

Uh oh!

a-maurice Feb 10, 2026

Uh oh!

AustinBenoit Feb 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: update minimum cmake version to 3.22 #1812

Are you sure you want to change the base?

chore: update minimum cmake version to 3.22 #1812

Uh oh!

Conversation

AustinBenoit commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Type of Change

Notes

Uh oh!

gemini-code-assist bot commented Jan 8, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ Integration test FAILED

Uh oh!

AustinBenoit commented Jan 9, 2026

Uh oh!

Uh oh!

a-maurice Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

AustinBenoit Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

a-maurice Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

AustinBenoit Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

AustinBenoit commented Jan 8, 2026 •

edited

Loading

github-actions bot commented Jan 8, 2026 •

edited

Loading

AustinBenoit Feb 10, 2026 •

edited

Loading