Skip to content

chore: Adding a .npmrc file to the root of the repo #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiranya911 merged 2 commits into from
Mar 11, 2020
Merged

chore: Adding a .npmrc file to the root of the repo #810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2782e61
chore: Adding a .npmrc file to the root of the repo
hiranya911 Mar 11, 2020
5339670
Removing the root-level .npmrc file
hiranya911 Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/publish_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
set -e
set -u

echo "//wombat-dressing-room.appspot.com/:_authToken=${NPM_AUTH_TOKEN}" >> ~/.npmrc
echo "//wombat-dressing-room.appspot.com/:_authToken=${NPM_AUTH_TOKEN}" >> .npmrc
Copy link
Member

@lahirumaramba lahirumaramba Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can assume that this runs in root? should we explicitly say /. npmrc?

Copy link
Contributor Author

@hiranya911 hiranya911 Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file should be added to the root of the repo/project. All the commands are already executed from the root of the repo. So file paths get resolved relative to that directory.


readonly UNPREFIXED_VERSION=`echo ${VERSION} | cut -c 2-`
npm publish dist/firebase-admin-${UNPREFIXED_VERSION}.tgz --registry https://wombat-dressing-room.appspot.com