Using async project ID discovery in ProjectManagement and InstanceId#728
Merged
hiranya911 merged 5 commits intomasterfrom Dec 16, 2019
Merged
Using async project ID discovery in ProjectManagement and InstanceId#728hiranya911 merged 5 commits intomasterfrom
hiranya911 merged 5 commits intomasterfrom
Conversation
nbegley
approved these changes
Dec 13, 2019
Contributor
nbegley
left a comment
nbegley
left a comment
There was a problem hiding this comment.
Project management changes LGTM.
| private readonly resourceName: string; | ||
| private readonly projectId: string; | ||
| private readonly requestHandler: ProjectManagementRequestHandler; | ||
| private projectId: string; |
Contributor
There was a problem hiding this comment.
It looks like this should be private projectId?: string; now
Contributor
Author
There was a problem hiding this comment.
Doesn't seem to be required for string and other primitive types.
lahirumaramba
approved these changes
Dec 16, 2019
This was referenced Feb 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #715
Using
utils.findProjectId()in ProjectManagement and InstanceId.