Skip to content

Changes saltSeparator type from string to Buffer#721

Merged
bojeil-google merged 1 commit intofirebase:masterfrom
ggirotto:master
Dec 11, 2019
Merged

Changes saltSeparator type from string to Buffer#721
bojeil-google merged 1 commit intofirebase:masterfrom
ggirotto:master

Conversation

@ggirotto
Copy link
Contributor

Fix an inconsistency where hash.saltSeparator on UserImportOptions is expecting a Buffer but its type on Typescript module was specified as a string

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ggirotto
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@ggirotto
Copy link
Contributor Author

Hi @bojeil-google. There's something else that I have to do or just wait for the merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments