fix(auth): Using the App-level http.Agent when fetching public key certificates#705
Merged
hiranya911 merged 3 commits intomasterfrom Nov 18, 2019
Merged
fix(auth): Using the App-level http.Agent when fetching public key certificates#705hiranya911 merged 3 commits intomasterfrom
hiranya911 merged 3 commits intomasterfrom
Conversation
bojeil-google
approved these changes
Nov 18, 2019
This was referenced Feb 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP call made by
verifyIdToken()to fetch public key certificates does not use thehttp.Agentset on theApp. This makes it challenging to useverifyIdToken()API when running behind a proxy. This PR fixes this limitation by injecting thehttp.Agentto theFirebaseTokenVerifier.Fixes #690
RELEASE NOTE: The
verifyIdToken()method now correctly uses thehttp.Agentconfigured during SDK initialization.