Updates multi-tenancy integration tests.#623
Merged
bojeil-google merged 1 commit intoauth-multi-tenancyfrom Aug 20, 2019
Merged
Updates multi-tenancy integration tests.#623bojeil-google merged 1 commit intoauth-multi-tenancyfrom
bojeil-google merged 1 commit intoauth-multi-tenancyfrom
Conversation
- Enables email action link generation tests after backend bug was fixed. - Adds email link sign-in test case. - Fixes issues with nested multi-tenancy tests not being skipped when they are supposed to. Confirmed multi-tenancy integration tests are passing in production.
wuyanna
approved these changes
Aug 16, 2019
hiranya911
approved these changes
Aug 20, 2019
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with a question.
| tenantAwareAuth = admin.auth().tenantManager().authForTenant(createdTenantId); | ||
| before(function() { | ||
| if (!createdTenantId) { | ||
| this.skip(); |
Contributor
There was a problem hiding this comment.
When does this happen? if the tenant creation fails in an earlier test?
Contributor
Author
There was a problem hiding this comment.
It seems the skip test is not getting applied for nested tests. So i added a check when no tenant is created (typically when the test is skipped or if tenant creation fails) to skip the nested tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Confirmed multi-tenancy integration tests are passing in production.