add FIREBASE_DATABASE_EMULATOR_HOST_VAR#596
Merged
Conversation
samtstern
approved these changes
Jul 18, 2019
Contributor
samtstern
left a comment
samtstern
left a comment
There was a problem hiding this comment.
@hiranya911 Jan and I did a bunch of manual testing today, this simplified version will work in conjunction with some changes to the emulator itself (which are also out for review)
hiranya911
suggested changes
Jul 19, 2019
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks @IanWyszynski. Looks pretty good. Just have some comments about the tests.
Contributor
Author
|
This is currently blocked on the minor version bump in firebase/firebase-js-sdk#2005, which must get merged first. |
hiranya911
suggested changes
Jul 19, 2019
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks @IanWyszynski. Code looks good. Please push the updated package-lock file so the tests can pass. Then I can merge.
egilmorez
reviewed
Jul 19, 2019
egilmorez
approved these changes
Jul 19, 2019
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Other than a tiny nit, comments have my blessing for style. Thanks!
jmwski
added a commit
that referenced
this pull request
Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support specifying database endpoint with FIREBASE_DATABASE_EMULATOR_HOST.