Closed
Conversation
maneesht
requested changes
Aug 1, 2025
test/unit/data-connect/data-connect-api-client-internal.spec.ts
Outdated
Show resolved
Hide resolved
added 9 commits
August 4, 2025 11:58
…anges include:queryref
…actored and renamed the 'executeGraphqlHelper' function to support the 'executeQuery' and 'executeMutation' functions.
…cleaned up unnecessary code.
… The two new functions are used to get different parameters and potentially throw detailed and tailored errors.
…into the connectorConfig so that executeGraphql and executeGraphqlRead don't try to retrieve data from wrong endpoints. Included unit tests for the executeMutation function.
…ned up some unnecessary comments.
ONATEMOWO
force-pushed
the
core-admin-init
branch
from
f18714c to
4f8ccdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written and completed the Firebase Core Admin Node SDK, following the provided API proposals and including some unit tests. Some of the additions include the queryRef functionality and the mutationRef functionalities. Please review the commits/changes for a deeper understanding of these additions.