Conversation
hiranya911
approved these changes
Jan 26, 2018
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with a couple of nits. Please wait for @bojeil-google to take a look before merging.
| @@ -15,7 +15,7 @@ | |||
| "@firebase/auth": { | |||
Contributor
There was a problem hiding this comment.
It is weird to have changes in the lock file without corresponding changes in package.json. Please revert.
src/auth/auth-api-request.ts
Outdated
| * before revocation will also be revoked on the Auth backend. Any request with an | ||
| * ID token generated before revocation will be rejected with a token expired error. | ||
| * Note that due to the fact that the timestamp is stored in seconds, any tokens minted in | ||
| * the same second as the revokation will still be valid. If there is a chance that a token |
Contributor
There was a problem hiding this comment.
typo: revokation --> revocation
test/integration/auth.spec.ts
Outdated
| .then((decodedIdToken) => { | ||
| // Verification should succeed. Revoke that user's session. | ||
| return admin.auth().revokeRefreshTokens(decodedIdToken.sub); | ||
| return new Promise(resolve => setTimeout(() => resolve( |
bojeil-google
approved these changes
Jan 29, 2018
src/auth/auth-api-request.ts
Outdated
| * ID token generated before revocation will be rejected with a token expired error. | ||
| * Note that due to the fact that the timestamp is stored in seconds, any tokens minted in | ||
| * the same second as the revocation will still be valid. If there is a chance that a token | ||
| * was minted in the last second, delay for 1 second before revoking. |
Contributor
There was a problem hiding this comment.
Extra space before was minted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a 1 second timeout in the integration tests to make sure revoke happens 1 second after minting. also comment