enable esModuleInterop in tsconfig to fix import issue#1825
Closed
tylim88 wants to merge 2 commits intofirebase:masterfrom
tylim88:master
Closed
enable esModuleInterop in tsconfig to fix import issue#1825tylim88 wants to merge 2 commits intofirebase:masterfrom tylim88:master
tylim88 wants to merge 2 commits intofirebase:masterfrom
tylim88:master
Conversation
2. change import as x to import x 3. fix some type issue: i. test/integration/auth.spec.ts ii. test/integration/firestore.spec.ts
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
my deduction is incorrect turn out the reason is that it simply doesn't have a default export this PR is not meaningful, close |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as for now
esModuleInteropis not enabled, this has caused some issues when importing, for example:with
@babel/preset-env, it is translated intoplayground
this import will not work because, in the built code, we have something like this

in the built code, the
__esModuleprop is set to truethe problem:
import x from 'y'is equivalent toconst x = require('y').defaultbut thedefaultprop is not defined(with__esModuleset to true,_interopRequireDefaultwill not return{ default: obj }and_firestore.defaultwill becomeundefined)the solution is to simply enable esModuleInterop in ts config
======================================
I did the changes needed for
esModuleInteropto work and fix some types along the way:import * as xtoimport xfor multiple filesno changes in public api