Conversation
jshcrowthe
approved these changes
Oct 27, 2017
Contributor
jshcrowthe
left a comment
jshcrowthe
left a comment
There was a problem hiding this comment.
One comment, but this looks good if you don't want to do anything different.
| # REINSTALL DEPENDENCIES # | ||
| ############################ | ||
| echo "[INFO] Removing lib/, and node_modules/..." | ||
| rm -rf lib/ node_modules/ |
Contributor
There was a problem hiding this comment.
Does it make sense to, since you're trying to clean install here, just do:
git clean -xdfAnd just prune everything that doesn't exist by default in the git tree?
Contributor
Author
There was a problem hiding this comment.
This is a good suggestion. But I think we need to add a few more entries to .gitignore before we do this. Will do as a separate PR.
Contributor
Author
|
Related to #121 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrating from
npm-shrinkwrap.jsontopackage-lock.json. This file is far more stable than the shrinkwrap, and it cannot be published with releases. Users who installfirebase-adminwill get the dependencies as stated in ourpackage.jsonfile. Package lock also gets automatically updated when we update thepackage.jsonfile.