feat(fis): Adding the admin.installations() API for deleting Firebase installation IDs#1187
feat(fis): Adding the admin.installations() API for deleting Firebase installation IDs#1187hiranya911 merged 10 commits intomasterfrom
Conversation
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
LGTM. Left one comment.
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Thanks Hiranya! Some nits and one link to update.
|
Thanks @egilmorez. I've responded to your comments. PTAL. |
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
Here's a couple of things to look at Hiranya. Thanks!
| - title: "Installations" | ||
| path: /docs/reference/admin/node/admin.installations.Installations-1 | ||
|
|
||
| - title: "admin.instanceId" |
There was a problem hiding this comment.
It's possible to add a "status: deprecated" flag here to create this kind of effect:
https://firebase.google.com/docs/reference/android/com/google/firebase/iid/package-summary?hl=en
There was a problem hiding this comment.
What does that look like in the yaml? Can you point me to an example?
src/installations/index.ts
Outdated
| *``` | ||
| * | ||
| * @param app Optional app whose `Installations` service to | ||
| * return. If not provided, the default `Installations` service will be |
There was a problem hiding this comment.
"Optional app whose Installations service to
- return." makes sense but isn't 100% grammatical.
"Optional app for which to return the Installations service" is valid but not great.
"Optional app whose Installations service should be
- returned." sounds better, but "should" seems weak.
I'll poll the tech writers and see who has a solution :)
4 participants
admin.installations()API.admin.instanceId()API. The implementation of this API now just invokes the installations API under the hood.admin.instanceId()retains backward compatibility by converting theFirebaseInstallationsErrorraised by the new implementation to the oldFirebaseInstanceIdErrortype. Error codes are the same, but the error message may defer.go/firebase-admin-fis
RELEASE NOTE: Added a new
admin.installations()API to replace the existingadmin.instanceId()API. Developers are advised to migrate to the new API for deleting Firebase instance IDs and installation IDs.