Skip to content

Expect that tests may run without root privileges #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hroncok merged 1 commit into from
Sep 12, 2018
Merged

Expect that tests may run without root privileges #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/test_ethtool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,13 @@ def _functions_accepting_devnames(self, devname):
'[Errno 95] Operation not supported')

self.assertIsInt(ethtool.get_sg(devname))
self.assertIsInt(ethtool.get_ufo(devname))

try:
self.assertIsInt(ethtool.get_ufo(devname))
except (OSError, IOError):
# This test may fail due to insufficient privileges
# That's IOError on 2.7, OSError (PermissionError) on 3
pass

self.assertIsInt(ethtool.get_tso(devname))

Expand Down
12 changes: 10 additions & 2 deletions tests/test_scripts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,21 @@ def test_show_coalesce_lo(self):

def test_show_offload_lo(self):
self.assertIsNone(peth.show_offload(loopback))

# Check if we have rights to obtain ufo and set proper expected output
try:
ethtool.get_ufo(loopback)
expected_ufo = 'on'
except (OSError, IOError):
expected_ufo = 'not supported'

self.assertEqual(self._output(),
'''scatter-gather: on
tcp segmentation offload: on
udp fragmentation offload: on
udp fragmentation offload: {expected_ufo}
generic segmentation offload: on
generic receive offload: on
'''
'''.format(expected_ufo=expected_ufo)
)

# Tests for another device
Expand Down