✨ Add IntEnum type that allows storing values of enum as integers in database#1337
✨ Add IntEnum type that allows storing values of enum as integers in database#1337KunxiSun wants to merge 19 commits intofastapi:mainfrom
IntEnum type that allows storing values of enum as integers in database#1337Conversation
…nto feat/IntEnum
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Motov Yurii <109919500+YuriiMotov@users.noreply.github.com>
Updates the `IntEnum` SQLAlchemy type to `SmallInteger`. This change reduces the storage size required for `IntEnum` columns when the full range of `Integer` is not needed.
Adds tests to ensure that integer enum fields are correctly handled in both Postgres and SQLite DDL generation.
Thanks for your code suggestion. I also changed the type from Integer to Small Integer, cuz I think the size of Integer is too large to be needed. |
There was a problem hiding this comment.
Looks interesting!
I think this feature is quite useful.
There seems to be no simple solution to configure int enums this way without creating custom TypeDecorator. This PR will provide such solution.
Implementation and tests look good to me.
We may want to describe this in docs, but maybe it's better to wait for Sebastian to validate the idea first
IntEnum type that allows storing values of enum as integers in database
|
I like this |
This comment was marked as resolved.
This comment was marked as resolved.
|
I think they could create a Alternatively, you could reuse sqlmodel.Enum and add a parameter to make it save the value, but that would imply that it determines the value through class introspection. |
I add a IntEnum type decorator which I used in my private project.
I wish it helps!