Closed
Conversation
- remove function scope that not needed - don't have access to code pen though.
Collaborator
|
@brigand Can you look at this? |
brigand
added a commit
to brigand/react
that referenced
this pull request
Apr 27, 2017
Contributor
|
@exiadbq thanks! I added these changes to the main tutorial PR. I'm not sure how to give you credit for the commit. |
Contributor
Author
|
@brigand nps, didn't know there was PR for that, otherwise I can commit there. Closing this one for now. |
gaearon
pushed a commit
that referenced
this pull request
May 1, 2017
* tutorial: adds note about onClick * tutorial: show full square component * merge * fixes line number * tutorial: misc changes * fixes Board render initial code sample * [tutorial] adds codepen links and misc small fixes * removes useless arrow functions, #9531 * {this.renderSquare} new lines * be more explicit about history state * fixes highlight * following along locally * changes todo to this.props.value * removes calculateWinner from initial codepens and includes it in tutorial * removes note about calculateWinner at end of file * adds debug-view and debug-view-final * removes debug view, updates codepen instructions * adds another codepen * tutorial.md * tutorial.md * tutorial.md * tutorial.md * Put . into links for consistency with docs * Make the very first change easier to follow * A few more changes
gaearon
pushed a commit
that referenced
this pull request
May 1, 2017
* tutorial: adds note about onClick * tutorial: show full square component * merge * fixes line number * tutorial: misc changes * fixes Board render initial code sample * [tutorial] adds codepen links and misc small fixes * removes useless arrow functions, #9531 * {this.renderSquare} new lines * be more explicit about history state * fixes highlight * following along locally * changes todo to this.props.value * removes calculateWinner from initial codepens and includes it in tutorial * removes note about calculateWinner at end of file * adds debug-view and debug-view-final * removes debug view, updates codepen instructions * adds another codepen * tutorial.md * tutorial.md * tutorial.md * tutorial.md * Put . into links for consistency with docs * Make the very first change easier to follow * A few more changes (cherry picked from commit e9d6f3f)
Contributor
Author
|
Hi @gaearon what was your consideration not including this change?
|
Collaborator
|
Can you send another PR on top of the current changes, and I’ll take a look? Thanks! |
flarnie
pushed a commit
that referenced
this pull request
Jun 12, 2017
* tutorial: adds note about onClick * tutorial: show full square component * merge * fixes line number * tutorial: misc changes * fixes Board render initial code sample * [tutorial] adds codepen links and misc small fixes * removes useless arrow functions, #9531 * {this.renderSquare} new lines * be more explicit about history state * fixes highlight * following along locally * changes todo to this.props.value * removes calculateWinner from initial codepens and includes it in tutorial * removes note about calculateWinner at end of file * adds debug-view and debug-view-final * removes debug view, updates codepen instructions * adds another codepen * tutorial.md * tutorial.md * tutorial.md * tutorial.md * Put . into links for consistency with docs * Make the very first change easier to follow * A few more changes (cherry picked from commit e9d6f3f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run lint).npm run prettier).npm run flow)../scripts/fiber/record-testsbefore submitting the pull request, and commit the resulting changes.