Add a few more code-pen examples of working code#9510
Closed
CaptRat wants to merge 1 commit intofacebook:masterfrom
Closed
Add a few more code-pen examples of working code#9510CaptRat wants to merge 1 commit intofacebook:masterfrom
CaptRat wants to merge 1 commit intofacebook:masterfrom
Conversation
Instead of (only) the final version, it would be really helpful for us newbies if you added more working code samples throughout. Once mine broke, I couldn't figure how to continue moving forward - didn't understand if I put changes in the correct places and didn't know where the code isn't _supposed_ to work.
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
Collaborator
|
cc @brigand, something you could look at? |
Contributor
|
@gaearon yep. |
Collaborator
|
This will be addressed by #9454. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of (only) the final version, it would be really helpful for us newbies if you added more working code samples throughout. Once mine broke, I couldn't figure how to continue moving forward - didn't understand if I put changes in the correct places and didn't know where the code isn't supposed to work.
Before submitting a pull request, please make sure the following is done:
master.npm test).npm run lint).npm run prettier).npm run flow)../scripts/fiber/record-testsbefore submitting the pull request, and commit the resulting changes.