Add onError to ReactDOMImg to complement onLoad#855
Merged
petehunt merged 1 commit intofacebook:masterfrom Feb 13, 2014
syranide:onerror
Merged
Add onError to ReactDOMImg to complement onLoad#855petehunt merged 1 commit intofacebook:masterfrom syranide:onerror
petehunt merged 1 commit intofacebook:masterfrom
syranide:onerror
Conversation
Contributor
|
seems legit |
Contributor
|
For FB people going to take this kind of code. When pulling in, make sure that you check for existing code that uses the same name using |
Contributor
Author
|
@petehunt Rebased. |
Contributor
|
pulling in |
petehunt
added a commit
that referenced
this pull request
Feb 13, 2014
Add onError to ReactDOMImg to complement onLoad
This was referenced Nov 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@spicyj added the the useful
onLoad, lets complement it withonErrorfor those times the images doesn't load. :)It is possible that we may want to overload
onLoadto sometimes emitonErrorinstead. I've seen people comment in various places that sometimes images fails to load but emitonLoadwith 0 width/height image instead. But I wasn't able to reproduce it myself in IE8-11 and edge versions of browsers.