Add meta tag in the header of HTML#4334
Merged
jimfb merged 2 commits intofacebook:masterfrom Jul 10, 2015
Merged
Conversation
docs/docs/tutorial.md
Outdated
Member
There was a problem hiding this comment.
Need to bump this if you're adding a line so that the correct line stays highlighted.
Contributor
Author
There was a problem hiding this comment.
I'm sorry I can't understand what you mean.
What should I change?
Member
There was a problem hiding this comment.
The 7 should become an 8. We use the {7} to highlight a line in the generated markup (see it in action @ http://facebook.github.io/react/docs/tutorial.html#adding-markdown)
Contributor
Author
There was a problem hiding this comment.
Ah, thanks! I understand!
I've changed that.
Contributor
|
Looks great, thanks! |
jimfb
added a commit
that referenced
this pull request
Jul 10, 2015
…f_html Add meta tag in the header of HTML in translated documentation.
jimfb
added a commit
that referenced
this pull request
Jul 17, 2015
…f_html Add meta tag in the header of HTML in translated documentation. (cherry picked from commit 6c0ab0b)
This was referenced Nov 30, 2023
This was referenced Feb 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #4267