[rcr] Reexport React.__COMPILER_RUNTIME.c or fallback to polyfill#31051
Closed
poteto wants to merge 10 commits intogh/poteto/10/basefrom
Closed
[rcr] Reexport React.__COMPILER_RUNTIME.c or fallback to polyfill#31051poteto wants to merge 10 commits intogh/poteto/10/basefrom
poteto wants to merge 10 commits intogh/poteto/10/basefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This was referenced Sep 24, 2024
josephsavona
reviewed
Oct 1, 2024
poteto
changed the title
josephsavona
reviewed
Oct 1, 2024
| // This symbol is added to tell the react devtools that this array is from | ||
| // useMemoCache. | ||
| // @ts-ignore | ||
| $[$empty] = true; |
Member
There was a problem hiding this comment.
should we put this in __DEV__? not sure if this affects the JIT by changing the hidden class or not
Member
Author
There was a problem hiding this comment.
hmm probably wouldn't hurt but im not sure if this gets called enough for hidden classes to kick in?
josephsavona
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR updates the standalone
react-compiler-runtimepackage toeither re-export
React.__COMPILER_RUNTIME.cor to use a userspacepolyfill.