Warn when defined methods are used in plain JS classes#2806
Merged
sebmarkbage merged 1 commit intofacebook:masterfrom Jan 13, 2015
Merged
Warn when defined methods are used in plain JS classes#2806sebmarkbage merged 1 commit intofacebook:masterfrom
sebmarkbage merged 1 commit intofacebook:masterfrom
Conversation
In ReactClass we use early validation to warn you if a accidentally defined propTypes in the wrong place or if you mispelled componentShouldUpdate. For plain JS classes there is no early validation process. Therefore, we wait to do this validation until the component is mounted before we issue the warning. This should bring us to warning-parity with ReactClass.
sebmarkbage
force-pushed
the
baseclass
branch
from
11b5486 to
2330962
Compare
sebmarkbage
added a commit
that referenced
this pull request
Jan 13, 2015
Warn when defined methods are used in plain JS classes
Member
|
After trying to pull this internally, I realized just how noisy this is in a testing environment. I didn't see it before BUT you can see it yourself by running testing |
Contributor
Author
|
It's probably because we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is building on top of #2805
In ReactClass we use early validation to warn you if an accidentally defined
propTypes in the wrong place or if you mispelled componentShouldUpdate.
For plain JS classes there is no early validation process. Therefore, we
wait to do this validation until the component is mounted before we issue
the warning.
This should bring us to warning-parity with ReactClass.