Update 14-communicate-between-components.md for grammatical changes#2760
Merged
zpao merged 1 commit intofacebook:masterfrom Dec 22, 2014
Merged
Update 14-communicate-between-components.md for grammatical changes#2760zpao merged 1 commit intofacebook:masterfrom
zpao merged 1 commit intofacebook:masterfrom
Conversation
Member
|
👍 |
zpao
added a commit
that referenced
this pull request
Dec 22, 2014
Update 14-communicate-between-components.md for grammatical changes
zpao
added a commit
that referenced
this pull request
Jan 17, 2015
Update 14-communicate-between-components.md for grammatical changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to improve grammatical parallelism, as expressions separated by commas should share similar form.
BEFORE: Subscribe to events in
componentDidMount(), unsubscribe incomponentWillUnmount(), and when you receive an event, callsetState().AFTER: Subscribe to events in
componentDidMount(), unsubscribe incomponentWillUnmount(), and callsetState()when you receive an event.