Add .nvmrc to fixtures/flight to automatically use Node 18#26255
Closed
unstubbable wants to merge 1 commit intofacebook:mainfrom
Closed
Add .nvmrc to fixtures/flight to automatically use Node 18#26255unstubbable wants to merge 1 commit intofacebook:mainfrom
.nvmrc to fixtures/flight to automatically use Node 18#26255unstubbable wants to merge 1 commit intofacebook:mainfrom
Conversation
The requirement for Node 18 (global `fetch`) was introduced in f0cf832.
unstubbable
force-pushed
the
flight-fixture-nvmrc
branch
from
43ca812 to
06a215e
Compare
unstubbable
changed the title
.nvmrc to fixtures/flight to automatically use node 18.nvmrc to fixtures/flight to automatically use Node 18
|
Comparing: 6ff1733...06a215e Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
Collaborator
Author
|
superseded by #26257 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The requirement for node 18 (global
fetch) was introduced in f0cf832.Summary
Because of the
.nvmrcfile in the project root, node 14 was automatically selected (with nvm being installed). When changing intofixtures/flightand runningyarn dev, the dev server failed withReferenceError: fetch is not defined(used inApp.js).How did you test this change?
Open browser at
localhost:3000.