[react-interactions] Event testing library improvements#17614
Merged
necolas merged 1 commit intofacebook:masterfrom Dec 18, 2019
Merged
[react-interactions] Event testing library improvements#17614necolas merged 1 commit intofacebook:masterfrom
necolas merged 1 commit intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5dcc3bd:
|
Contributor
Author
|
After we merge this I was thinking of moving it to |
necolas
force-pushed
the
react-interactions/testing-library
branch
from
29c8b64 to
e06bdd2
Compare
trueadm
approved these changes
Dec 16, 2019
Contributor
trueadm
left a comment
trueadm
left a comment
There was a problem hiding this comment.
LGTM, I like how clean it is with these changes. :)
necolas
force-pushed
the
react-interactions/testing-library
branch
2 times, most recently
from
fd69c3f to
6e18505
Compare
Contributor
Author
|
I'm not going to land this or any other PR to this repo until we get to the bottom of why CI tasks aren't running on my PRs |
Introduces a state machine around pointer events to produce more accurate mock touch events. This allows multi-touch unit tests to be written entirely in terms of mock pointer interactions, while producing the expected 'changedTouches', 'targetTouches', and 'touches' fields for mock touch events.
necolas
force-pushed
the
react-interactions/testing-library
branch
from
6e18505 to
5dcc3bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a state machine around pointer events to produce more accurate mock
touch events. This allows multi-touch unit tests to be written entirely in
terms of mock pointer interactions, while producing the expected
'changedTouches', 'targetTouches', and 'touches' fields for mock touch events.