[react-interactions] Remove Focus/FocusWithin root event types#17555
Merged
trueadm merged 1 commit intofacebook:masterfrom Dec 9, 2019
Merged
[react-interactions] Remove Focus/FocusWithin root event types#17555trueadm merged 1 commit intofacebook:masterfrom
trueadm merged 1 commit intofacebook:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b014678:
|
Add missing type
trueadm
force-pushed
the
improve-focus
branch
from
24a08a3 to
b014678
Compare
necolas
approved these changes
Dec 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Focus and FocusWithin event responders to remove their root event types. Instead, we attach a set of events to the window once and track focus visible and other properties as globals. We then track the same events in the target phase of the responders and correleate behaviors to ensure the same expectations from before continue to be valid.
This will have a big impact on performance and memory, as having possibly thousands of root events subscribed at once can impact performance.