Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub#13598
Merged
aweary merged 2 commits intofacebook:masterfrom Sep 8, 2018
Merged
Conversation
EventPluginHub injectComponentTree was exposed for react-native-web, but wasn't actually being used by the project. They were using EventPluginHub through ReactDOM's secret internals, but that was removed in facebook#13539 This removes the unused injectComponentTree export, refactors the ResponderEventPlugin test so it doesn't depend on it, and also adds EventPluginHub to the exports to unbreak react-native-web
Details of bundled changes.Comparing: b87aabd...e9ade0f schedule
Generated by 🚫 dangerJS |
Collaborator
|
I think this might be insufficient because it's likely RNW actually needs |
Contributor
Author
|
I think you're right. In that case we can just add it back to ReactDOM secret internals, and re-export it? |
Collaborator
|
Yeah but that can increase the bundle size. At least let's just export the smallest unit we can (that method alone). |
gaearon
approved these changes
Sep 8, 2018
Collaborator
gaearon
left a comment
gaearon
left a comment
There was a problem hiding this comment.
Please test that this fixes RNW
aweary
force-pushed
the
event-plugin-hub-unstable-native-deps
branch
from
2913463 to
e9ade0f
Compare
Contributor
Author
|
With these changes to React Native for Web I verified that the reproducing example from necolas/react-native-web#1096 no longer throws with a local build form this branch. I also verified the same with the examples application in the RNW repo. |
Collaborator
|
Coolio |
This was referenced Sep 13, 2018
Merged
Collaborator
|
Should be fixed in 16.5.1 |
|
@aweary Great work! Could you make a pr with the changes to rnw? |
This was referenced Sep 14, 2018
ghost
mentioned this pull request
Simek
pushed a commit
to Simek/react
that referenced
this pull request
Oct 25, 2018
…ntPluginHub (facebook#13598) * Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub injectComponentTree was exposed for react-native-web, but wasn't actually being used by the project. They were using EventPluginHub through ReactDOM's secret internals, but that was removed in facebook#13539 This removes the unused injectComponentTree export, refactors the ResponderEventPlugin test so it doesn't depend on it, and also adds EventPluginHub to the exports to unbreak react-native-web * Re-export injectEventPluginsByName from ReactDOM internals
This was referenced Nov 1, 2018
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…ntPluginHub (facebook#13598) * Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub injectComponentTree was exposed for react-native-web, but wasn't actually being used by the project. They were using EventPluginHub through ReactDOM's secret internals, but that was removed in facebook#13539 This removes the unused injectComponentTree export, refactors the ResponderEventPlugin test so it doesn't depend on it, and also adds EventPluginHub to the exports to unbreak react-native-web * Re-export injectEventPluginsByName from ReactDOM internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13589
injectComponentTreewas exposed for react-native-web, but wasn't actually being used by the project. There don't appear to be any call sites forinjectComponentTreein www either (FB Internal).RNW is using
EventPluginHubthrough ReactDOM's secret internals, but that was removed in #13539This removes the unused
injectComponentTreeexport, refactors theResponderEventPlugintest so it doesn't depend on it, and also addsEventPluginHubto the exports to unbreak RNW with 16.5cc @necolas