[WIP] fix(SelectEventPlugin): reset mouseDown after drop event fires#11380
Closed
tobiasandersen wants to merge 1 commit intofacebook:masterfrom
Closed
[WIP] fix(SelectEventPlugin): reset mouseDown after drop event fires#11380tobiasandersen wants to merge 1 commit intofacebook:masterfrom
tobiasandersen wants to merge 1 commit intofacebook:masterfrom
Conversation
Collaborator
|
We can take something like this but only after a thorough investigation that explains why it happens. If you're not confident in the fix, I think we won't take it. Thanks for PR though! |
Author
|
Yeah this definitely shouldn't get merged. I was planning on doing some more investigation, but haven't had the time. Sorry for just leaving it here. |
Collaborator
|
See #13422 for a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR most probably isn't ready, it's rather intended to fix (or at least highlight the problems of) #11379. The problem is that
mouseDownnever gets reset after the drop event, since this plugin never receivestopMouseUpastopLevelTypewhen dropping.What I did here fixes the problem, but I feel like the proper solution would be to make sure that the
topMouseUpevent is received.