Skip to content

Comments

Remove unnecessary event whitelist in production#10802

Merged
gaearon merged 3 commits intofacebook:masterfrom
gaearon:remove-unnecessary-prod-whitelist
Sep 27, 2017
Merged

Remove unnecessary event whitelist in production#10802
gaearon merged 3 commits intofacebook:masterfrom
gaearon:remove-unnecessary-prod-whitelist

Conversation

@gaearon
Copy link
Collaborator

@gaearon gaearon commented Sep 24, 2017

Shaves off 150 bytes post gzip. Seems like there’s no need to run this validation in production?

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just find a way to crush all of these.

@gaearon
Copy link
Collaborator Author

gaearon commented Sep 24, 2017

After ES modules we can turn them into numeric constants that should be free. (?)

@gaearon gaearon merged commit c0a87b2 into facebook:master Sep 27, 2017
gaearon added a commit that referenced this pull request Sep 28, 2017
Fixes a size regression I introduced in #10802.
@gaearon gaearon deleted the remove-unnecessary-prod-whitelist branch September 28, 2017 23:47
gaearon added a commit that referenced this pull request Sep 29, 2017
Fixes a size regression I introduced in #10802.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants