[Gatsby Docs Update] Initial version of new sidebar#10707
Closed
flarnie wants to merge 4 commits intofacebook:gatsbyfrom
Closed
[Gatsby Docs Update] Initial version of new sidebar#10707flarnie wants to merge 4 commits intofacebook:gatsbyfrom
flarnie wants to merge 4 commits intofacebook:gatsbyfrom
Conversation
Contributor
Author
|
Major concerns here:
|
Contributor
Author
|
At this point if nobody has blockers I'm inclined to land this, so that anyone can work on top of it. Will do that tomorrow unless I get changes requested. 😁 |
**what is the change?:** - Adds media queries and JS to make sidebar collapse/expand from a sticky bottom bar on small screen sizes - Many TODOs still open! This is just an initial version. **why make this change?:** Moving closer to Joe's fantastic design. :) **test plan:** Manual testing - Flarnie will insert a gif **issue:** Various items under the `Sidebar Component` on this checklist; https://github.com/bvaughn/react/wiki/Gatsby-check-list
**what is the change?:** We skim the items in the 'defaultActiveSection' to find the currently active one, and display it's title in the sticky responsive bottom navbar. Before I had just plugged in the section title as a placeholder. **why make this change?:** It's better this way. One step closer to Joe's shiny new design. :) **test plan:** Manually tested (Flarnie will insert a screenshot) **issue:** Sidebar items on this checklist; https://github.com/bvaughn/react/wiki/Gatsby-check-list
flarnie
force-pushed
the
responsiveSidebarGatsbyDocsUpdate
branch
from
21096d3 to
547f651
Compare
Contributor
Author
|
Just pushed an update the fixes the title in the bottom navbar: |
flarnie
changed the title
Contributor
|
Picking this up for the moment. |
bvaughn
reviewed
Sep 18, 2017
| // TODO: memoize to save doing O(n) on the active section items + subitems every | ||
| // time. | ||
| function findActiveItemTitle(location, defaultActiveSection) { | ||
| const {items} = defaultActiveSection; |
Contributor
There was a problem hiding this comment.
This line causes errors for me.
yarn build fails with:
WebpackError: Cannot read property 'items' of null
yarn dev shows a runtime redbox with:
TypeError: Cannot read property 'items' of undefined
Contributor
There was a problem hiding this comment.
Note that I happened to have this page open when running yarn dev:
http://localhost:8000/blog/2013/06/12/community-roundup.html
Contributor
|
Seems a little busted? 😁
|
Contributor
|
@joecritch I think you meant #10735 |
Contributor
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
sticky bottom bar on small screen sizes
Let's either use this as a discussion starter or continue work on top of it. 🏗🙌
why make this change?:
Moving closer to Joe's fantastic design. :)
test plan:
Manual testing -
issue:
Various items under the
Sidebar Componenton this checklist;https://github.com/bvaughn/react/wiki/Gatsby-check-list