Modify proguard rules for Fresco gif support#8501
Closed
cmcewen wants to merge 2 commits intofacebook:masterfrom
Closed
Modify proguard rules for Fresco gif support#8501cmcewen wants to merge 2 commits intofacebook:masterfrom
cmcewen wants to merge 2 commits intofacebook:masterfrom
Conversation
|
By analyzing the blame information on this pull request, we identified @charpeni and @AndrewJack to be potential reviewers. |
ghost
added
GH Review: review-needed
CLA Signed
Contributor
|
Not again! However, GIF and WebP support will not be added to the core, I will refer you to this discussion #8455 for more information. Thank you for this catch, I will temporary add this to the documentation that i'm working on it. |
Contributor
Author
|
@charpeni sounds good - let me know if I can help. Going to leave this open till that's added in case anyone else runs into this problem |
ghost
added
the
CLA Signed
bartolkaruza
pushed a commit
to immidi/react-native
that referenced
this pull request
Aug 3, 2016
Summary: Motivation facebook#8455 Fixes facebook#8501 With a bonus fix typo !  Closes facebook#8951 Differential Revision: D3647816 Pulled By: mkonicek fbshipit-source-id: e0349275045cae2922b4bb43bcb99af4c6ef1170
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using proguard with Fresco gif support doesn't work due to stripping some classes - see facebook/fresco#1177
Test plan (required)
Create an Android application with the necessary dependencies (#7760) and Proguard turned on and see that a gif will appear correctly