[RFC][ListView] Add getInnerViewNode, scrollTo, scrollWithoutAnimationTo#765
Closed
ide wants to merge 1 commit intofacebook:masterfrom
Closed
[RFC][ListView] Add getInnerViewNode, scrollTo, scrollWithoutAnimationTo#765ide wants to merge 1 commit intofacebook:masterfrom
ide wants to merge 1 commit intofacebook:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
I think I need a little more context about how this is used. Do you have an example implementation you can point me to? |
ide
force-pushed
the
listview-api-1
branch
4 times, most recently
from
d8149ce to
4f542cd
Compare
ide
force-pushed
the
listview-api-1
branch
2 times, most recently
from
651667d to
010f811
Compare
After building some scroll view components (pull-to-refresh, infinite scroll) one of the most important features I found was composition of different scroll views. This diff adds scroll view methods to ListView so that it too acts like a scroll view and can be composed. This is an RFC because I have another approach that is a little more robust but perhaps more obtuse.
mganandraj
pushed a commit
to mganandraj/react-native
that referenced
this pull request
Oct 28, 2021
* Fix animation bug (facebook#763) * pod install * fix pod errors * fix pod errors * fix pod errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After building some scroll view components (pull-to-refresh, infinite scroll) one of the most important features I found was composition of different scroll views. This diff adds scroll view methods to ListView so that it too acts like a scroll view and can be composed.
This is an RFC because I have another approach that is a little more robust but perhaps more obtuse. See #766.