Deleted unnecessary 'use strict' in new project templates#6322
Closed
wwwsevolod wants to merge 2 commits intofacebook:masterfrom
Closed
Deleted unnecessary 'use strict' in new project templates#6322wwwsevolod wants to merge 2 commits intofacebook:masterfrom
wwwsevolod wants to merge 2 commits intofacebook:masterfrom
Conversation
Contributor
Contributor
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
Contributor
|
@facebook-github-bot shipit |
Contributor
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
CLA Signed
Contributor
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
Contributor
|
Just a note, I think this was premature. Until #5796 lands 'use strict' is still necessary in modules in RN by default. |
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary:Hello there! Since React Native generates `index.*.js` files with usage of ES6 modules, `'use strict'` became unnecessary. http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code > Module code is always strict mode code. Closes facebook/react-native#6322 Differential Revision: D3017181 Pulled By: vjeux fb-gh-sync-id: 39e0fe703b8d8a0093b952f2c18a36d0d28e1020 shipit-source-id: 39e0fe703b8d8a0093b952f2c18a36d0d28e1020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there!
Since React Native generates
index.*.jsfiles with usage of ES6 modules,'use strict'became unnecessary.http://www.ecma-international.org/ecma-262/6.0/#sec-strict-mode-code