Add basic test for NetworkReporter and CDP Network domain#54049
Closed
motiz88 wants to merge 2 commits intofacebook:mainfrom
Closed
Add basic test for NetworkReporter and CDP Network domain#54049motiz88 wants to merge 2 commits intofacebook:mainfrom
motiz88 wants to merge 2 commits intofacebook:mainfrom
Conversation
Summary: TSIA Changelog: [Internal] Differential Revision: D83825727
Summary: Changelog: [Internal] Adds `JsiIntegrationTest`-based tests for the C++ layer responsible for handling the CDP `Network` domain. The tests use `NetworkReporter` to mimic the behaviour of a React Native platform that is generating network events. NOTE: There are **significant problems** with the `NetworkReporter` / `NetworkHandler` singleton design: cross-Host and cross-Instance data pollution/corruption, inability to inspect multiple Hosts at once, inconsistency between the singleton's state and the CDP session's state, etc. The singletons similarly lack any kind of mechanism for test isolation (e.g. methods for clearing state between tests). As we iteratively fix these problems, the tests will require updating. Differential Revision: D83746505
meta-cla
bot
added
the
CLA Signed
Contributor
|
This pull request has been merged in fc60030. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Adds
JsiIntegrationTest-based tests for the C++ layer responsible for handling the CDPNetworkdomain. The tests useNetworkReporterto mimic the behaviour of a React Native platform that is generating network events.NOTE: There are significant problems with the
NetworkReporter/NetworkHandlersingleton design: cross-Host and cross-Instance data pollution/corruption, inability to inspect multiple Hosts at once, inconsistency between the singleton's state and the CDP session's state, etc. The singletons similarly lack any kind of mechanism for test isolation (e.g. methods for clearing state between tests). As we iteratively fix these problems, the tests will require updating.Differential Revision: D83746505