Add toDynamic conversion for RadialGradient#54041
Closed
lenaic wants to merge 3 commits intofacebook:mainfrom
Closed
Add toDynamic conversion for RadialGradient#54041lenaic wants to merge 3 commits intofacebook:mainfrom
lenaic wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
lenaic
force-pushed
the
export-D83788007
branch
from
5572a5c to
d01a23c
Compare
lenaic
pushed a commit
to lenaic/react-native-macos
that referenced
this pull request
Oct 2, 2025
Summary: Implement toDynamic conversion of the RadialGradient following the parse logic as described here: https://www.internalfb.com/code/fbsource/[28de0c66daab]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/RadialGradient.kt?lines=33-129 Changelog: [Internal] Differential Revision: D83788007
added 3 commits
October 2, 2025 17:47
Summary: Adding toDynamic conversion to `ColorStop` and `ValueUnit` structs which are being used by the linear and radial gradient data structures. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D83788006
Summary: Implement toDynamic conversion of the LinearGradient following the parse logic as described here: https://www.internalfb.com/code/fbsource/[5fa7eb2b733a]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/LinearGradient.kt?lines=24-76 Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D83788005
Summary: Implement toDynamic conversion of the RadialGradient following the parse logic as described here: https://www.internalfb.com/code/fbsource/[28de0c66daab]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/RadialGradient.kt?lines=33-129 Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D83788007
lenaic
force-pushed
the
export-D83788007
branch
from
d01a23c to
bc91c9d
Compare
Contributor
|
This pull request has been merged in d9d3b3e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implement toDynamic conversion of the RadialGradient following the parse logic as described here: https://www.internalfb.com/code/fbsource/[28de0c66daab]/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/style/RadialGradient.kt?lines=33-129
Changelog: [Internal]
Differential Revision: D83788007