Replace React.ElementProps with React.ElementConfig in createAnimatedComponent.js#54034
Closed
SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D83750127
Closed
Replace React.ElementProps with React.ElementConfig in createAnimatedComponent.js#54034SamChou19815 wants to merge 1 commit intofacebook:mainfrom SamChou19815:export-D83750127
React.ElementProps with React.ElementConfig in createAnimatedComponent.js#54034SamChou19815 wants to merge 1 commit intofacebook:mainfrom
SamChou19815:export-D83750127
Conversation
…matedComponent.js` Summary: `React.ElementConfig` is often the better choice. See https://flow.org/en/docs/react/types/#toc-react-elementprops Changelog: [Internal] Differential Revision: D83750127
meta-cla
bot
added
the
CLA Signed
|
@SamChou19815 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83750127. |
Contributor
|
This pull request has been merged in 041b4c3. |
Collaborator
|
This pull request was successfully merged by @SamChou19815 in 041b4c3 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
React.ElementConfigis often the better choice. See https://flow.org/en/docs/react/types/#toc-react-elementpropsChangelog: [Internal]
Differential Revision: D83750127