add support for symbolication of precompiled React.xcframework#54033
Closed
cipolleschi wants to merge 4 commits intofacebook:mainfrom
Closed
add support for symbolication of precompiled React.xcframework#54033cipolleschi wants to merge 4 commits intofacebook:mainfrom
cipolleschi wants to merge 4 commits intofacebook:mainfrom
Conversation
Summary: This change remove some unnecessary logs and improve the logging functions for the prebuilds ## Changelog: [IOS] [CHANGED] - Updated logging functions for prebuilds Pull Request resolved: facebook#53976 Test Plan: Run: ``` RCT_USE_RN_DEP=1 RCT_USE_PREBUILT_RNCORE=1 bundle exec pod install ``` Differential Revision: D83481709 Pulled By: cipolleschi
Summary: This commit updates the cocoapods source for RNDependencies so that the source for the package is the locally downloaded file so we don't download twice! ## Changelog: [IOS] [FIXED] - Update the `source`property to avoid multiple downloads Differential Revision: D83753188 Pulled By: cipolleschi
Summary: This commit adds building blocks to support the symbolication of the XCFrameworks on request. Symbol files are big and only needed if you need to debug React Native itself - f.ex. if you are a framework developer like Expo. This change introduces some helper function that are needed to handle the dSYMS: - `processDSYMs` the main function that unzip the symbols and prepare the framework for them - `remap_sourcemaps_for_symbols` a support function that creates a mapping symbol -> file so that the debug can interpret them properly - `generate_plist_content` a support function that generates the plist with all the mappings These functions are used in the next commit of the stack. ## Changelog: [Internal] - Added building blocks to support symbolication Differential Revision: D83753189 Pulled By: cipolleschi
Summary: This commit adds support for symbolication of the XCFrameworks on request. Symbol files are big and only needed if you need to debug React Native itself - f.ex. if you are a framework developer like Expo. Symbolication can be performed by setting the `RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1` environment variable. This will cause the `ReactNativeCoreUtils` class to download symbol files and symbolicate the XFrameworks by doing the following: - After downloading the requested React.XCFramework the symbols will also be downloaded and places in the artifacts folder. - The XCFrameworks will be expanded and the folders in the symbol archive will be extracted into the XCFramework before it is zipped up again. <img width="400" alt="image" src="https://github.com/user-attachments/assets/ec8dd2e1-c7f8-4d5f-a3b6-b8ffbb678c95" /> ## Changelog: [IOS] [FIXED] - Added support for symbolication of precompiled React.xcframework Differential Revision: D83753187 Pulled By: cipolleschi
meta-cla
bot
added
the
CLA Signed
|
@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83753187. |
Contributor
|
@cipolleschi merged this pull request in 07f40ec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This commit adds support for symbolication of the XCFrameworks on request.
Symbol files are big and only needed if you need to debug React Native itself - f.ex. if you are a framework developer like Expo.
Symbolication can be performed by setting the
RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1environment variable. This will cause theReactNativeCoreUtilsclass to download symbol files and symbolicate the XFrameworks by doing the following:Changelog:
[IOS] [FIXED] - Added support for symbolication of precompiled React.xcframework
Differential Revision: D83753187
Pulled By: cipolleschi