Don't flash the performance monitor there's no metro connection#54019
Closed
sbuggay wants to merge 2 commits intofacebook:mainfrom
Closed
Don't flash the performance monitor there's no metro connection#54019sbuggay wants to merge 2 commits intofacebook:mainfrom
sbuggay wants to merge 2 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
Summary: The DevMenu path for perf analyzing no-ops. This is due to incorrectly not inverting the bool result of `pauseAndAnalyzeBackgroundTrace()`. See https://www.internalfb.com/code/fbsource/%5Bfcebbc02e701%5D/xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/perfmonitor/PerfMonitorOverlayManager.kt?lines=73-75. {F1982418482} Changelog: [Internal] Reviewed By: shwanton Differential Revision: D83691623
…book#54019) Summary: Currently the performance monitor flickers on boot if there's no metro connection. This change checks first if we have a packager before enabling the monitor. No metro connection: {F1982423105} Metro connection: {F1982423112} Changelog: [Internal] Reviewed By: shwanton Differential Revision: D83701372
sbuggay
force-pushed
the
export-D83701372
branch
from
cb4f5c4 to
d1ee0d9
Compare
sbuggay
added a commit
to sbuggay/react-native
that referenced
this pull request
Oct 2, 2025
…book#54019) Summary: Currently the performance monitor flickers on boot if there's no metro connection. This change checks first if we have a packager before enabling the monitor. No metro connection: {F1982423105} Metro connection: {F1982423112} Changelog: [Internal] Reviewed By: shwanton Differential Revision: D83701372
Contributor
|
This pull request has been merged in 53dc68a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently the performance monitor flickers on boot if there's no metro connection. This change checks first if we have a packager before enabling the monitor.
No metro connection:
{F1982423105}
Metro connection:
{F1982423112}
Changelog: [Internal]
Differential Revision: D83701372