Mark hasTVPreferredFocus as deprecated#52043
Closed
Abbondanzo wants to merge 1 commit intofacebook:mainfrom
Closed
Mark hasTVPreferredFocus as deprecated#52043Abbondanzo wants to merge 1 commit intofacebook:mainfrom
Abbondanzo wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: The `hasTVPreferredFocus` prop is functionally similar to the `focusable` prop. On iOS, the props are identical. The primary difference appears on Android, where the prop attempts to request focus when set to true. Attempting to invoke imperative API calls through declarative means has been [a source of confusion](react-native-tvos/react-native-tvos#237) and we should instead recommend requesting focus through imperative means, like calling `focus()` on a specific view's ref instead. Workarounds presented rely on lifecycle methods to request focus natively. This change only marks these methods as deprecated on JS. In the following version, they will be removed from the public API. Changelog: [General][Deprecated] - Deprecate `hasTVPreferredFocus` Differential Revision: D76732539
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D76732539 |
Contributor
|
This pull request has been merged in cfb6c96. |
Collaborator
|
This pull request was successfully merged by @Abbondanzo in cfb6c96 When will my fix make it into a release? | How to file a pick request? |
douglowder
pushed a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Jun 30, 2025
This commit is empty for React Native TV. Summary: Pull Request resolved: facebook/react-native#52043 The `hasTVPreferredFocus` prop is functionally similar to the `focusable` prop. On iOS, the props are identical. The primary difference appears on Android, where the prop attempts to request focus when set to true. Attempting to invoke imperative API calls through declarative means has been [a source of confusion](#237) and we should instead recommend requesting focus through imperative means, like calling `focus()` on a specific view's ref instead. Workarounds presented rely on lifecycle methods to request focus natively. This change only marks these methods as deprecated on JS. In the following version, they will be removed from the public API. Changelog: [General][Deprecated] - Deprecate `hasTVPreferredFocus` Reviewed By: andrewdacenko Differential Revision: D76732539 fbshipit-source-id: 64912b4dacb76cd40e79148c1082d8ed8f573879
Contributor
|
@Abbondanzo @cipolleschi just a heads up from the React Native TV repo -- this change caused a slight regression in the TV repo when it was merged from upstream, as this API is used there. For the record, If possible, it would be great to add me to the review for any future PRs like this that affect TV APIs 😄 Thanks very much, and I apologize for not catching this sooner! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
hasTVPreferredFocusprop is functionally similar to thefocusableprop. On iOS, the props are identical. The primary difference appears on Android, where the prop attempts to request focus when set to true. Attempting to invoke imperative API calls through declarative means has been a source of confusion and we should instead recommend requesting focus through imperative means, like callingfocus()on a specific view's ref instead. Workarounds presented rely on lifecycle methods to request focus natively.This change only marks these methods as deprecated on JS. In the following version, they will be removed from the public API.
Changelog: [General][Deprecated] - Deprecate
hasTVPreferredFocusDifferential Revision: D76732539