Refactor PerformanceEntry as std::variant#50995
Closed
huntie wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73860532 |
huntie
force-pushed
the
export-D73860532
branch
from
06a26a2 to
5c5e5ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73860532 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73860532 |
Summary: Pull Request resolved: facebook#50995 Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`. This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431. Changelog: [Internal] Reviewed By: rshest Differential Revision: D73860532
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D73860532 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
May 1, 2025
Summary: Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`. This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431. Changelog: [Internal] Reviewed By: rubennorte, rshest Differential Revision: D73860532
Contributor
|
This pull request has been merged in 1135f10. |
Collaborator
|
This pull request was successfully merged by @huntie in 1135f10 When will my fix make it into a release? | How to file a pick request? |
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#50995 Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`. This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431. Changelog: [Internal] Reviewed By: rubennorte, rshest Differential Revision: D73860532 fbshipit-source-id: f3b7a7444d2456370620c1a1ba9a43f118cb9730
ghost
pushed a commit
to discord/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: facebook#50995 Refactors our previous single-struct representation for `PerformanceEntry` ([see MDN](https://developer.mozilla.org/en-US/docs/Web/API/PerformanceEntry)) as a `std::variant`. This maps closely to the `PerformanceEntry` type inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431. Changelog: [Internal] Reviewed By: rubennorte, rshest Differential Revision: D73860532 fbshipit-source-id: f3b7a7444d2456370620c1a1ba9a43f118cb9730
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors our previous single-struct representation for
PerformanceEntry(see MDN) as astd::variant— to precisely switch between the possiblePerformanceEntryvariations.This maps closely to the
PerformanceEntrytype inheritance in the web spec, and makes this type substantially cleaner to extend and work with in D73861431.Changelog: [Internal]
Differential Revision: D73860532